[main] Fix formatting for dotnet format#30587
Merged
mattleibow merged 1 commit intomainfrom Jul 11, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a dotnet format crash issue by simplifying null-conditional expressions in ListView renderers. The change replaces verbose null checking with more concise null-conditional operators to prevent formatter crashes.
- Simplifies null-conditional expressions using the
?.operator - Fixes dotnet format crash issue referenced in Roslyn issue #79338
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Controls/src/Core/Compatibility/Handlers/ListView/iOS/ListViewRenderer.cs | Replaced explicit null check with null-conditional operator in UpdateSpinnerColor method |
| src/Compatibility/Core/src/iOS/Renderers/ListViewRenderer.cs | Applied same null-conditional operator simplification in corresponding renderer |
Member
Author
|
/backport to inflight/current |
Contributor
|
Started backporting to inflight/current: https://github.com/dotnet/maui/actions/runs/16227488238 |
PureWeen
added
the
area-infrastructure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Make the formatter not crash: dotnet/roslyn#79338